tools: use lts node in notify-on-push workflow#63084
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 4, 2026
Merged
tools: use lts node in notify-on-push workflow#63084nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
MikeMcC399
reviewed
May 2, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
aduh95
reviewed
May 3, 2026
Without pinning Node.js, the runner defaults to Node 20 and npx falls back to [email protected] instead of 6.0.0 (requires Node 22+). Version 5 does not recognise the ffi subsystem, causing false invalid-commit alerts. Signed-off-by: Nenad Spasenic <[email protected]>
nsinfoPRO
force-pushed
the
fix/notify-on-push-workflow-set-node-lts
branch
from
60167cf to
6c9f340
Compare
aduh95
approved these changes
May 3, 2026
aduh95
added
the
author ready
targos
approved these changes
May 4, 2026
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 6ef8dc8 |
Contributor
|
Congratulations for the successful PR, despite my incorrect comments! Sorry once again for that! https://github.com/nodejs/node/actions/runs/25353511115/job/74337950931 for example shows that the workflow is correctly working in production and is pulling the v6, not v5 release of |
aduh95
pushed a commit
that referenced
this pull request
May 5, 2026
Without pinning Node.js, the runner defaults to Node 20 and npx falls back to [email protected] instead of 6.0.0 (requires Node 22+). Version 5 does not recognise the ffi subsystem, causing false invalid-commit alerts. Signed-off-by: Nenad Spasenic <[email protected]> PR-URL: #63084 Fixes: #63070 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without pinning Node.js, the runner defaults to Node 20 and npx falls back to
[email protected]instead of6.0.0(requires Node 22+). Version 5 doesn't recognise theffisubsystem, causing false invalid-commit alerts.Fixes: #63070